Re: [PATCH] ARM: imx_v6_v7_defconfig: Remove KERNEL_LZO config

From: Otavio Salvador
Date: Sat May 27 2023 - 09:29:44 EST


Hello Shawn,

Em sáb., 27 de mai. de 2023 às 09:44, Shawn Guo <shawnguo@xxxxxxxxxx> escreveu:
>
> On Wed, May 24, 2023 at 08:48:26AM +0200, Arnd Bergmann wrote:
> > On Tue, May 23, 2023, at 23:28, Otavio Salvador wrote:
> > > The KERNEL_GZIP is used in most config and is the default, there is no
> > > clear reason to diverge so let default be used.
> > >
> > > Signed-off-by: Otavio Salvador <otavio@xxxxxxxxxxxxxxxx>
> >
> > I don't mind that change, but it seems odd to single this one out, as
> > there are many other options in that particular defconfig that
> > stick out more, picking LZO seems like a reasonable choice for slightly
> > faster booting, though ZSTD would be the more modern choice.
> >
> > If you are looking into cleaning up this file, maybe see if we can
> > kill off these options:
> >
> > CONFIG_EXPERT=y
> > CONFIG_ARCH_FORCE_MAX_ORDER=13
> > CONFIG_CMDLINE="noinitrd console=ttymxc0,115200"
> > CONFIG_CS89x0_PLATFORM=y # none of these four are in dts files
> > CONFIG_SMC91X=y
> > CONFIG_SMC911X=y
> > CONFIG_SMSC911X=y
> > CONFIG_STAGING=y
> > CONFIG_STAGING_MEDIA=y
> > CONFIG_VIDEO_IMX_MEDIA=y # not graduated from staging after 6 years
> > CONFIG_EXT2_FS=y
> > CONFIG_EXT3_FS=y # select EXT4 instead
> > CONFIG_ISO9660_FS=m
> >
> > I have not investigated why any of them were added originally,
> > so it's likely that some are actually needed.
>
> Would you investigate the suggested options and see if we can clean up
> more than just KERNEL_LZO?

Sure. I'll view them. I'll prepare more patches for it.

--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750