Re: [PATCH v3 0/2] Fixes from evsel__group_pmu_name asan error

From: Arnaldo Carvalho de Melo
Date: Sun May 28 2023 - 09:19:30 EST


Em Fri, May 26, 2023 at 12:44:40PM -0700, Ian Rogers escreveu:
> evsel__group_pmu_name triggered an asan error as a list_head was cast
> to an evsel, when it was the head, and the accessed as if it were a
> full evsel. Further investigation showed problematic list iteration
> for evsel__group_pmu_name whilst the list was being sorted so switch
> to pre-computation.
>
> v3: Rebase on perf-tools-next (branch getting ready for 6.5) rather
> than perf-tools (fixes for 6.4).
> v2: Address review comments/feedback from Adrian Hunter
> <adrian.hunter@xxxxxxxxx>.

Thanks, applied.

- Arnaldo


> Ian Rogers (2):
> perf evsel: evsel__group_pmu_name fixes
> perf evsel: for_each_group fixes
>
> tools/perf/util/evsel.c | 31 ++++-----------
> tools/perf/util/evsel.h | 26 +++++++-----
> tools/perf/util/evsel_fprintf.c | 1 +
> tools/perf/util/parse-events.c | 70 +++++++++++++++++++++++++++------
> 4 files changed, 84 insertions(+), 44 deletions(-)
>
> --
> 2.41.0.rc0.172.g3f132b7071-goog
>

--

- Arnaldo