Re: [PATCH v9 3/5] ksm: add ksm zero pages for each process

From: xu xin
Date: Sun May 28 2023 - 21:48:57 EST



Already fixed in PACTH v10.

>Hi Yang,
>
>kernel test robot noticed the following build errors:
>
>[auto build test ERROR on akpm-mm/mm-everything]
>[also build test ERROR on linus/master v6.4-rc3 next-20230525]
>[If your patch is applied to the wrong git tree, kindly drop us a note.
>And when submitting patch, we suggest to use '--base' as documented in
>https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
>url: https://github.com/intel-lab-lkp/linux/commits/Yang-Yang/ksm-count-all-zero-pages-placed-by-KSM/20230524-153333
>base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
>patch link: https://lore.kernel.org/r/20230524055800.20498-1-yang.yang29%40zte.com.cn
>patch subject: [PATCH v9 3/5] ksm: add ksm zero pages for each process
>config: nios2-defconfig
>compiler: nios2-linux-gcc (GCC) 12.1.0
>reproduce (this is a W=1 build):
> mkdir -p ~/bin
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/intel-lab-lkp/linux/commit/c9da8338fa8f95db948cd4d826053d8f6cbcf19c
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review Yang-Yang/ksm-count-all-zero-pages-placed-by-KSM/20230524-153333
> git checkout c9da8338fa8f95db948cd4d826053d8f6cbcf19c
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross W=1 O=build_dir ARCH=nios2 olddefconfig
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross W=1 O=build_dir ARCH=nios2 SHELL=/bin/bash
>
>If you fix the issue, kindly add following tag where applicable
>| Reported-by: kernel test robot <lkp@xxxxxxxxx>
>| Closes: https://lore.kernel.org/oe-kbuild-all/202305251415.OLELa7qJ-lkp@xxxxxxxxx/
>
>All errors (new ones prefixed by >>):
>
> mm/memory.c: In function 'zap_pte_range':
>>> mm/memory.c:1419:60: error: incompatible type for argument 1 of 'ksm_notify_unmap_zero_page'
> 1419 | ksm_notify_unmap_zero_page(mm, ptent);
> | ^~
> | |
> | struct mm_struct *
> In file included from mm/memory.c:56:
> include/linux/ksm.h:116:53: note: expected 'pte_t' but argument is of type 'struct mm_struct *'
> 116 | static inline void ksm_notify_unmap_zero_page(pte_t pte)
> | ~~~~~~^~~
> mm/memory.c:1419:33: error: too many arguments to function 'ksm_notify_unmap_zero_page'
> 1419 | ksm_notify_unmap_zero_page(mm, ptent);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/ksm.h:116:20: note: declared here
> 116 | static inline void ksm_notify_unmap_zero_page(pte_t pte)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~