Re: [PATCH] clk: imx: clk-imxrt1050: fix memory leak in imxrt1050_clocks_probe

[Kai Ma]

On Thursday, May 18, 2023 6:34:38 PM CST Abel Vesa wrote:
> On 23-04-18 11:34:51, Kai Ma wrote:
> > Use devm_of_iomap() instead of of_iomap() to automatically
> > handle the unused ioremap region. If any error occurs, regions allocated by
> > kzalloc() will leak, but using devm_kzalloc() instead will automatically
> > free the memory using devm_kfree().
> > 
> > Also, fix error handling of hws by adding unregister_hws label, which
> > unregisters remaining hws when iomap failed.
> > 
> > Fixes: 7154b046d8f3 ("clk: imx: Add initial support for i.MXRT1050 clock driver")
> > Signed-off-by: Kai Ma <kaima@xxxxxxxxxxx>
> 
> Reviewed-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> 
> Stephen, can you apply this through clk-fixes?
> 

Thanks for your review, I am glad to let you know that I am a student at a
university and we collaborate to contribute to the Linux kernel. Here we
have some similar patches for clk. Could you please take care of them?

[1] https://lore.kernel.org/linux-arm-kernel/DU0PR04MB9417B63DE97D4A2A77B4176C88969@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/T/
[2] https://lore.kernel.org/linux-arm-kernel/20230503070607.2462-1-lyx2022@xxxxxxxxxxx/T/
[3] https://lore.kernel.org/linux-arm-kernel/dc0f2863-d5d5-5102-eb8e-ceea92c03fda@xxxxxxxxxxx/
[4] https://lore.kernel.org/linux-arm-kernel/9a2ab7ec-07ee-255f-a143-9b6c8df7c1e2@xxxxxxxxx/

Thank you very much!

Regards,
Kai Ma

Attachment: signature.asc
Description: This is a digitally signed message part.