Re: [PATCH linux-next] ARM: unwind: use ex_frame with CONFIG_UNWINDER_FRAME_POINTER

[Linus Walleij]

On Thu, May 18, 2023 at 10:58 AM <guo.ziliang@xxxxxxxxxx> wrote:

> From: guo ziliang <guo.ziliang@xxxxxxxxxx>
>
> We define ex_frame with CONFIG_UNWINDER_FRAME_POINTER in struct stackframe,
> struct stackframe
> {
>         ......
> #ifdef CONFIG_UNWINDER_FRAME_POINTER
>     bool ex_frame;
> #endif
> };
> but we just use ex_frame without CONFIG_UNWINDER_FRAME_POINTER in
> return_address() and unwind_frame().
> Maybe we should fix it.
>
> Signed-off-by: guo ziliang <guo.ziliang@xxxxxxxxxx>

Looks reasonable:
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Is it possible to create a .config which expose this problem?
Then mention in the commit message "if you select A and B
then compilation fails..."

Yours,
Linus Walleij