Re: [PATCH V7 4/8] pinctrl: qcom: Add IPQ5018 pinctrl driver

[Sricharan Ramabadhran]

Hi Linus,

On 5/22/2023 1:02 PM, Linus Walleij wrote:
> On Fri, May 19, 2023 at 2:55 PM Sricharan Ramabadhran
> <quic_srichara@xxxxxxxxxxx> wrote:
>
> > Add pinctrl definitions for the TLMM of IPQ5018.
> >
> > Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > Co-developed-by: Nitheesh Sekar <quic_nsekar@xxxxxxxxxxx>
> > Signed-off-by: Nitheesh Sekar <quic_nsekar@xxxxxxxxxxx>
> > Co-developed-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> > Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> > Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
> > ---
> >   [v7] No change
>
> This looks mostly fine, but I want you to consider Andy's remarks.
> With those addressed:
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
 Thanks.
 Sure, will fix and repost with Andy's comments addressed.

> Can this file and the bindings be applied independently of the rest
> of the patches? In that case I can apply v8 bindings+this patch to
> the pinctrl tree.

 Yes, this can go independently. Will repost v8 tomorrow.

Regards,
 Sricharan