Re: [PATCH] riscv: vector: Fixup modules compile error

From: Conor Dooley
Date: Mon May 29 2023 - 09:43:06 EST


On Mon, May 29, 2023 at 03:38:45AM -0400, guoren@xxxxxxxxxx wrote:
> From: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
>
> Some .ko also need the riscv_v_user_allowed symbol.
>
> ERROR: modpost: "riscv_v_user_allowed" [arch/riscv/kvm/kvm.ko]
> undefined!
> make[3]: ***
> [/home/guoren/source/kernel/linux/scripts/Makefile.modpost:136:
> Module.symvers] Error 1
>
> Signed-off-by: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Guo Ren <guoren@xxxxxxxxxx>
> ---
> arch/riscv/kernel/vector.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c
> index 1c4ac821e008..3ae08816d608 100644
> --- a/arch/riscv/kernel/vector.c
> +++ b/arch/riscv/kernel/vector.c
> @@ -129,6 +129,7 @@ bool riscv_v_user_allowed(void)
> {
> return riscv_v_get_cur_ctrl(current) == PR_RISCV_V_VSTATE_CTRL_ON;
> }
> +EXPORT_SYMBOL(riscv_v_user_allowed);

Is there a reason that this should not be EXPORT_SYMBOL_GPL()?

I figure Andy will roll this into this next revision..

Cheers,
Conor.

Attachment: signature.asc
Description: PGP signature