Re: [PATCH] ACPICA: Slightly simplify an error message in acpi_ds_result_push()

From: Rafael J. Wysocki
Date: Mon May 29 2023 - 10:13:47 EST


On Mon, May 29, 2023 at 8:31 AM Christophe JAILLET
<christophe.jaillet@xxxxxxxxxx> wrote:
>
> 'object' is known to be NULL at this point. There is little value to log
> it twice in the error message.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

ACPICA changes require (at least) a pull request submitted to the
upstream ACPICA project on GitHub.

If you have submitted one, please resend the Linux patch with a Link
tag pointing to the corresponding upstream ACPICA pull request.

Thanks!

> ---
> drivers/acpi/acpica/dswstate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/acpica/dswstate.c b/drivers/acpi/acpica/dswstate.c
> index d3841ded3a81..75338a13c802 100644
> --- a/drivers/acpi/acpica/dswstate.c
> +++ b/drivers/acpi/acpica/dswstate.c
> @@ -146,8 +146,8 @@ acpi_ds_result_push(union acpi_operand_object *object,
>
> if (!object) {
> ACPI_ERROR((AE_INFO,
> - "Null Object! Obj=%p State=%p Num=%u",
> - object, walk_state, walk_state->result_count));
> + "Null Object! State=%p Num=%u",
> + walk_state, walk_state->result_count));
> return (AE_BAD_PARAMETER);
> }
>
> --
> 2.34.1
>