Re: [PATCH v2 2/2] dt-bindings: mips: Add bindings for TP-Link HC220 G5 v1 board

[Liviu Dudau]

On Mon, May 29, 2023 at 10:00:20PM +0100, Conor Dooley wrote:
> Hey,

Hi Conor,

> 
> On Mon, May 29, 2023 at 04:08:33PM +0100, Liviu Dudau wrote:
> > Add bindings for the compatible string used for the TP-Link's
> > HC220 G5 V1 board, a wireless AP based on MT7621.
> > 
> > Signed-off-by: Liviu Dudau <liviu@xxxxxxxxxxx>
> 
> Two process things:
> - Please run get_maintainer.pl against the current git tree - you seem
>   to have missed 2 of the 3 dt-bindings maintainers. I don't mind my
>   omission, but omitting Krzysztof means you're submitting patches based
>   on a tree that is over a year old.

Appologies for that, I should have check get_maintainer.pl rather than looking
at the output of git log for the file.

> - Please don't send a v2 in reply to the v1.

Sorry, I'm not sure why that makes any difference. Reason for sending it as a
reply was the fact that last conversation was more than two weeks ago, people
might have forgot the context. This way it's all in one thread.

> 
> > ---
> >  Documentation/devicetree/bindings/mips/ralink.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mips/ralink.yaml b/Documentation/devicetree/bindings/mips/ralink.yaml
> > index 704b5b5951271..53c1f66353770 100644
> > --- a/Documentation/devicetree/bindings/mips/ralink.yaml
> > +++ b/Documentation/devicetree/bindings/mips/ralink.yaml
> > @@ -80,6 +80,7 @@ properties:
> >            - enum:
> >                - gnubee,gb-pc1
> >                - gnubee,gb-pc2
> > +              - tplink,hc220-g5-v1
> 
> For the actual change though,
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Many thanks!

Best regards,
Liviu

> 
> Thanks,
> Conor.
> 
> >            - const: mediatek,mt7621-soc
> >  
> >  additionalProperties: true
> > -- 
> > 2.40.1
> > 



-- 
Everyone who uses computers frequently has had, from time to time,
a mad desire to attack the precocious abacus with an axe.
       	   	      	     	  -- John D. Clark, Ignition!