Re: [PATCH v4 0/9] serial: sc16is7xx: fix GPIO regression and rs485 improvements

[Hugo Villeneuve]

On Tue, 30 May 2023 01:31:28 +0300
andy.shevchenko@xxxxxxxxx wrote:

> Mon, May 29, 2023 at 10:07:02AM -0400, Hugo Villeneuve kirjoitti:
> > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> > 
> > Hello,
> > this patch series mainly fixes a GPIO regression and improve RS485 flags and
> > properties detection from DT.
> > 
> > It now also includes various small fixes and improvements that were previously
> > sent as separate patches, but that made testing everything difficult.
> > 
> > Patch 1 fixes an issue when debugging IOcontrol register. After testing the GPIO
> > regression patches (patches 6 and 7, tests done by Lech Perczak), it appers that
> > this patch is also necessary for having the correct IOcontrol register values.
> > 
> > Patch 2 introduces a delay after a reset operation to respect datasheet
> > timing recommandations.
> 
> These two patches are w/o Fixes tag, they should be moved in the series further
> as I explained before.

Your explanation was not clear.

Anyway, I moved them in position 7 and 8.

 
> > Patch 3 fixes an issue with init of first port during probing.
> > 
> > Patch 4 fixes a bug with the output value when first setting the GPIO direction.
> > 
> > Patch 5 is a refactor of GPIO registration code.
> > 
> > Patches 6 and 7 fix a GPIO regression by (re)allowing to choose GPIO function
> > for GPIO pins shared with modem status lines.
> > 
> > Patch 8 allows to read common rs485 device-tree flags and properties.
> > 
> > Patch 9 improves comments about chip variants.
> > 
> > I have tested the changes on a custom board with two SC16IS752 DUART using a
> > Variscite IMX8MN NANO SOM.
> 
> -- 
> With Best Regards,
> Andy Shevchenko