Re: linux-next: build failure after merge of the perf tree

From: Ian Rogers
Date: Mon May 29 2023 - 22:17:13 EST


On Mon, May 29, 2023 at 4:05 PM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
> Hi all,
>
> After merging the perf tree, today's linux-next build (powerpc perf)
> failed like this:
>
> arch/powerpc/util/kvm-stat.c: In function 'kvm_add_default_arch_event':
> arch/powerpc/util/kvm-stat.c:207:21: error: implicit declaration of function 'pmu_have_event'; did you mean 'perf_pmu__have_event'? [-Werror=implicit-function-declaration]
> 207 | if (pmu_have_event("trace_imc", "trace_cycles")) {
> | ^~~~~~~~~~~~~~
> | perf_pmu__have_event
>
> Caused by commit
>
> 1eaf496ed386 ("perf pmu: Separate pmu and pmus")
>
> I have used the perf tree from next-20230525 for today.

Apologies, the function was renamed to perf_pmus__have_event. I've
sent out a patch and confirmed this was the only issue on a cross
compile build with "NO_LIBELF=1 NO_LIBTRACEEVENT=1".

The 1-liner fix is here:
https://lore.kernel.org/lkml/20230530021433.3107580-1-irogers@xxxxxxxxxx/

Thanks,
Ian



> --
> Cheers,
> Stephen Rothwell