Re: [PATCH v1 1/1] nvme: complete directly for hctx with only one ctx mapping

From: Stanley Chu
Date: Mon May 29 2023 - 22:50:07 EST


On Tue, May 30, 2023 at 10:45 AM Po-Wen Kao <powen.kao@xxxxxxxxxxxx> wrote:
>
> From: Ed Tsai <ed.tsai@xxxxxxxxxxxx>
>
> Refer to
> commit f168420c62e7
> ("blk-mq: don't redirect completion for hctx withs only one ctx mapping")
> When nvme applies a 1:1 mapping of hctx and ctx, there will be no remote
> request.
>
> But for ufs, the submission and completion queue could be asymmetric.
> (e.g. Multiple SQs share one CQ) Therefore, 1:1 mapping of hctx and
> ctx won't complete request on the submission cpu. In this situation,
> put this condition in block layer could violate the
> QUEUE_FLAG_SAME_FORCE, as a result, move this back to nvme.
>
> Signed-off-by: Ed Tsai <ed.tsai@xxxxxxxxxxxx>
> Signed-off-by: Po-Wen Kao <powen.kao@xxxxxxxxxxxx>

Reviewed-by: Stanley Chu <stanley.chu@xxxxxxxxxxxx>