Re: [PATCH v2 1/2] soc: hisilicon: Support HCCS driver on Kunpeng SoC

From: lihuisong (C)
Date: Mon May 29 2023 - 22:53:53 EST

Hi Sudeep,

在 2023/5/25 16:12, lihuisong (C) 写道:

在 2023/5/25 15:35, Sudeep Holla 写道:
On Thu, May 25, 2023 at 10:41:51AM +0800, lihuisong (C) wrote:
Hi Sudeep,

Here, the interface is used to determine whether a port is in use or
If we just use 'status', it cannot inidicates its own meaning by name.
What do you think?

How about "port_status" or "port-status" ?
The meaning of this status is a little board.
How about 'enable'? just a read-only entry.

"using_status" --> "enable" ? What do you think?
Its original purpose was to determine whether a port is in use or enabled.

In addition, I happen to have another problem when replace ioremap() with acpi_os_ioremap().

The driver selects 'M' in .config to compile.
The driver cannot be compiled if we use acpi_os_ioremap().
The compiling log is as follows:
make -j80
  CALL    scripts/
  CC [M]  drivers/soc/hisilicon/kunpeng_hccs.o
  MODPOST Module.symvers
ERROR: modpost: "acpi_os_ioremap" [drivers/soc/hisilicon/kunpeng_hccs.ko] undefined!
scripts/Makefile.modpost:136: recipe for target 'Module.symvers' failed
make[1]: *** [Module.symvers] Error 1
Makefile:1978: recipe for target 'modpost' failed
make: *** [modpost] Error 2

The driver can be compiled if we selects 'Y' or export symbol for acpi_os_ioremap.
So we have to export symbol for acpi_os_ioremap.
I plan to do it in another patch, and not in this series in case of blocking the upload of this driver.
What do you think?
Someone disagree we do it here. please see the patch[1].
So we have to keep what it was.