[PATCH] fs/buffer: using __bio_add_page in submit_bh_wbc()

From: gouhao
Date: Mon May 29 2023 - 23:33:30 EST


From: Gou Hao <gouhao@xxxxxxxxxxxxx>

In submit_bh_wbc(), bio is newly allocated, so it
does not need any merging logic.

And using bio_add_page here will execute 'bio_flagged(
bio, BIO_CLONED)' and 'bio_full' twice, which is unnecessary.

Signed-off-by: Gou Hao <gouhao@xxxxxxxxxxxxx>
---
fs/buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/buffer.c b/fs/buffer.c
index a7fc561758b1..5abc26d8399d 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -2760,7 +2760,7 @@ static void submit_bh_wbc(blk_opf_t opf, struct buffer_head *bh,

bio->bi_iter.bi_sector = bh->b_blocknr * (bh->b_size >> 9);

- bio_add_page(bio, bh->b_page, bh->b_size, bh_offset(bh));
+ __bio_add_page(bio, bh->b_page, bh->b_size, bh_offset(bh));
BUG_ON(bio->bi_iter.bi_size != bh->b_size);

bio->bi_end_io = end_bio_bh_io_sync;
--
2.20.1