Re: [PATCH] fs/buffer: using __bio_add_page in submit_bh_wbc()

From: Gou Hao
Date: Mon May 29 2023 - 23:53:02 EST




在 2023/5/30 11:39, Matthew Wilcox 写道:
On Tue, May 30, 2023 at 11:32:39AM +0800, gouhao@xxxxxxxxxxxxx wrote:
From: Gou Hao <gouhao@xxxxxxxxxxxxx>

In submit_bh_wbc(), bio is newly allocated, so it
does not need any merging logic.

And using bio_add_page here will execute 'bio_flagged(
bio, BIO_CLONED)' and 'bio_full' twice, which is unnecessary.
https://lore.kernel.org/linux-fsdevel/20230502101934.24901-5-johannes.thumshirn@xxxxxxx/

You could send some Reviewed-by: tags to that patch series.

Ok, I didn't notice this patchset, thank you for your review.

--
thanks,
Gou Hao