Re: [PATCH v4] Staging: rts5208: rtsx: Moved else statement to same line with else if

From: Dan Carpenter
Date: Tue May 30 2023 - 00:15:40 EST


On Tue, May 30, 2023 at 07:52:59AM +0530, Deepanshu Kartikey wrote:
> drivers/staging/rts5208/rtsx.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index 2284a96abcff..47dacef0aaf8 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
> chip->srb->device->id,
> (u8)chip->srb->device->lun);
> chip->srb->result = DID_BAD_TARGET << 16;
> - }
> -
> - /* we've got a command, let's do it! */
> - else {
> + } else {
> + /* we've got a command, let's do it! */

This code is part of series of if else statements that all have the
same issue but you're only changing one. Please change them all.

regards,
dan carpenter