Re: [PATCH 2/2] samples: rust: add `SgTable` and `ScatterList` selftests

From: Greg KH
Date: Tue May 30 2023 - 03:32:50 EST


On Tue, May 30, 2023 at 02:48:21PM +0800, Qingsong Chen wrote:
> Add a selftest module to provide a temporary place to put "pure tests"
> for Rust funtionality and wrappers.

Is this for in-kernel tests, or userspace tests? If userspace, you
should follow the proper test reporting protocol the rest of the kernel
uses. If in-kernel, it should follow the format that the in-kernel test
currently has to be consistent. From what I could tell here, you aren't
following either, but I might be totally wrong.

thanks,

greg k-h