Re: [PATCH 1/2] hexagon/traps.c: use KSYM_NAME_LEN in array size
From: Petr Mladek
Date: Tue May 30 2023 - 04:59:51 EST
On Mon 2023-05-29 16:43:36, Maninder Singh wrote:
> kallsyms_lookup which in turn calls for kallsyms_lookup_buildid()
> writes on index "KSYM_NAME_LEN - 1".
>
> Thus array size should be KSYM_NAME_LEN.
>
> for hexagon it was defined as "128" directly.
> and commit '61968dbc2d5d' changed define value to 512,
> So both were missed to update with new size.
>
> Fixes: 61968dbc2d5d ("kallsyms: increase maximum kernel symbol length to 512")
As mentioned by Michael Ellerman for the 2nd patch, the right upstream
commit is:
b8a94bfb3395 ("kallsyms: increase maximum kernel symbol length to 512")
> Co-developed-by: Onkarnath <onkarnath.1@xxxxxxxxxxx>
> Signed-off-by: Onkarnath <onkarnath.1@xxxxxxxxxxx>
> Signed-off-by: Maninder Singh <maninder1.s@xxxxxxxxxxx>
With the updated commit hash:
Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>
Best Regards,
Petr