Re: [PATCH v2 1/1] scsi: ufs: core: Make UFS_MCQ_NUM_DEV_CMD_QUEUES a module parameter

From: Powen Kao (高伯文)
Date: Tue May 30 2023 - 06:04:41 EST


On Tue, 2023-05-30 at 09:24 +0200, AngeloGioacchino Del Regno wrote:
>
> I imagine that MediaTek's UFS IP does not support dev_cmd_queues=1,
> does it?
>
> In that case, this should not be a UFS module parameter, but a
> setting that
> you provide from ufs-mediatek instead.
>
> Regards,
> Angelo

Hi Angelo

Our IP do work with dev_cmd_queues=1, but sacrifice one hwq
specifically for dev commands leaving (N-1) hwq to (N) CPUs for
submission doesn't make much sense.

Actually I would prefer making it a dts property than module parameter,
however, to match convention like `poll_queues` module parameters is
chosen.

Po-Wen