Re: [PATCH V3,net] net: mana: Fix perf regression: remove rx_cqes, tx_cqes counters

From: patchwork-bot+netdevbpf
Date: Tue May 30 2023 - 06:11:09 EST


Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@xxxxxxxxxx>:

On Fri, 26 May 2023 08:38:57 -0700 you wrote:
> The apc->eth_stats.rx_cqes is one per NIC (vport), and it's on the
> frequent and parallel code path of all queues. So, r/w into this
> single shared variable by many threads on different CPUs creates a
> lot caching and memory overhead, hence perf regression. And, it's
> not accurate due to the high volume concurrent r/w.
>
> For example, a workload is iperf with 128 threads, and with RPS
> enabled. We saw perf regression of 25% with the previous patch
> adding the counters. And this patch eliminates the regression.
>
> [...]

Here is the summary with links:
- [V3,net] net: mana: Fix perf regression: remove rx_cqes, tx_cqes counters
https://git.kernel.org/netdev/net/c/1919b39fc6ea

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html