Re: [PATCH v4 33/41] tty: serial: handle HAS_IOPORT dependencies

[Greg Kroah-Hartman]

On Tue, May 16, 2023 at 01:00:29PM +0200, Niklas Schnelle wrote:
> In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> not being declared. We thus need to add HAS_IOPORT as dependency for
> those drivers using them unconditionally. For 8250 based drivers some
> support MMIO only use so fence only the parts requiring I/O ports.

Why can't you have dummy inb()/outb() so we don't need these #ifdefs all
over the place in .c files?  Was that documented somewhere?  We do that
for other driver/hardware apis, why are these so special they don't
deserve that?

Otherwise this makes old drivers really messy with these additional
#ifdefs, something we never wanted to do in .c files.

thanks,

greg k-h