Re: [PATCH] serial: 8250: omap: convert to modern PM ops

[Greg Kroah-Hartman]

On Fri, May 19, 2023 at 08:44:31AM +0300, Tony Lindgren wrote:
> * Arnd Bergmann <arnd@xxxxxxxxxx> [230517 20:20]:
> > From: Arnd Bergmann <arnd@xxxxxxxx>
> > 
> > The new uart_write() function is only called from suspend/resume code, causing
> > a build warning when those are left out:
> > 
> > drivers/tty/serial/8250/8250_omap.c:169:13: error: 'uart_write' defined but not used [-Werror=unused-function]
> > 
> > Remove the #ifdefs and use the modern pm_ops/pm_sleep_ops and their wrappers
> > to let the compiler see where it's used but still drop the dead code.
> 
> This looks good to me as an alternative for Geert's fix. If Geert's
> fix gets applied first, this needs to be rabased.

No need for rebase, it applied cleanly.

thanks,

greg k-h