Re: [cocci] [PATCH] Coccinelle: kmerr: increase check list

[Julia Lawall]

On Tue, 30 May 2023, Markus Elfring wrote:

> …
> > +++ b/scripts/coccinelle/null/kmerr.cocci
> …
> > @@ -51,7 +51,7 @@ position any withtest.p;
> >  identifier f;
> >  @@
> >
> > -x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
> > +x@p1 = \(kmalloc\|devm_kmalloc\|kmalloc_array\|devm_kmalloc_array\|krealloc_array\|kzalloc\|devm_kzalloc\|kcalloc\|devm_kcalloc\|kasprintf\|devm_kasprintf\|kstrdup\|kstrdup_const\)(...);
> >  ...
> >  x1@p = f@p2(...);
> >  if (!x1) S
>
> Can it be nicer to specify desired function names on multiple lines
> for such a SmPL disjunction?
>
> Would you sort them according to their call probability?

Please don't follow either of these suggestions.

julia