Re: [PATCH 2/2] samples: rust: add `SgTable` and `ScatterList` selftests

From: Miguel Ojeda
Date: Tue May 30 2023 - 10:23:26 EST


On Tue, May 30, 2023 at 8:54 AM Qingsong Chen
<changxian.cqs@xxxxxxxxxxxx> wrote:
>
> Add a selftest module to provide a temporary place to put "pure tests"
> for Rust funtionality and wrappers.

Thanks for the patch series! Quick note on this: the `selftest` sample
module was a temporary place we had in the `rust` branch to put some
non-doctest tests until we had a better way to run them.

Even if we wanted to keep this approach for tests like this, this part
should be in its own patch -- that way you can credit Boqun properly
and avoid adding his SoB on code he did not write (which he may not
agree with).

Cheers,
Miguel