Re: [PATCH] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

[Ross Lagerwall]

> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Thursday, May 25, 2023 10:31 AM
> To: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>; Ingo Molnar <mingo@xxxxxxxxxx>; Borislav Petkov <bp@xxxxxxxxx>; Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>; x86@xxxxxxxxxx <x86@xxxxxxxxxx>; Juergen Gross <jgross@xxxxxxxx>; Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>; Peter Jones <pjones@xxxxxxxxxx>; Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx <xen-devel@xxxxxxxxxxxxxxxxxxxx>
> Subject: Re: [PATCH] iscsi_ibft: Fix finding the iBFT under Xen Dom 0 
>  
> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe.
> 
> On 24.05.2023 18:05, Ross Lagerwall wrote:
> > --- a/arch/x86/xen/setup.c
> > +++ b/arch/x86/xen/setup.c
> > @@ -772,8 +772,14 @@ char * __init xen_memory_setup(void)
> >         * UNUSABLE regions in domUs are not handled and will need
> >         * a patch in the future.
> >         */
> 
> I think this comment now wants to move ...
> 
> > -     if (xen_initial_domain())
> > +     if (xen_initial_domain()) {
> 
> ... here. And then likely you want a blank line ...
> 
> >                xen_ignore_unusable();
> 
> ... here.

OK

> 
> > +             /* Reserve 0.5 MiB to 1 MiB region so iBFT can be found */
> > +             xen_e820_table.entries[xen_e820_table.nr_entries].addr = 0x80000;
> > +             xen_e820_table.entries[xen_e820_table.nr_entries].size = 0x80000;
> > +             xen_e820_table.entries[xen_e820_table.nr_entries].type = E820_TYPE_RESERVED;
> > +             xen_e820_table.nr_entries++;
> 
> Surely this can be omitted when !CONFIG_ISCSI_IBFT_FIND?
> 

Yes, good point. I will fix that.

Thanks,
Ross