Re: [PATCH v2 1/2] media: dt-bindings: alvium: add document YAML binding

From: Krzysztof Kozlowski
Date: Tue May 30 2023 - 11:53:50 EST


On 26/05/2023 19:39, Tommaso Merciai wrote:
> Add documentation of device tree in YAML schema for the ALVIUM
> Camera from Allied Vision Inc.
>


> +
> + camera: alvium@3c {
> + compatible = "alliedvision,alvium";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_csi0_pwn>, <&pinctrl_csi0_rst>, <&pinctrl_csi_mclk>;
> + reg = <0x3c>;
> + clocks = <&clk IMX8MP_CLK_IPP_DO_CLKO2>;
> + clock-names = "xclk";
> + assigned-clocks = <&clk IMX8MP_CLK_IPP_DO_CLKO2>;
> + assigned-clock-parents = <&clk IMX8MP_CLK_24M>;
> + assigned-clock-rates = <24000000>;
> + streamon-delay = <20>;
> + powerdown-gpios = <&gpio2 11 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>;
> + status = "okay";

Please apply all my comments from v1. I don't see improvements.

Best regards,
Krzysztof