Re: [PATCH] clocksource/drivers/imx-gpt: Use only a single name for functions

From: Daniel Lezcano
Date: Tue May 30 2023 - 12:18:19 EST

On 30/05/2023 17:31, Uwe Kleine-König wrote:
Helo Daniel,

On Tue, Mar 28, 2023 at 11:15:14AM +0200, Uwe Kleine-König wrote:
When looking at the data structs defining the different behaviours of
the GPT blocks in different SoCs it's not helpful that the same
functions are used with different names.

So drop the cpp defines and use the original names.

This commit was generated using:

perl -i -e 'my %m; while (<>) { if (/^#define (imx[a-zA-Z0-6_]*)\s(imx[a-zA-Z0-6_]*)/) {$m{$1} = $2; } else { foreach my $f (keys %m) {s/$f/$m{$f}/; } print; } }' drivers/clocksource/timer-imx-gpt.c

This patch has no effect on the generated code.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

This patch was generated against v6.3-rc1. On the upside it still
applies fine to v6.4-rc1 and even current next/master. On the downside I
didn't get any feedback on it. Is this patch still on your radar?

Well, it is back on the radar now :)

Without feedback from the driver maintainer I'll pick the patch in a few days

<> │ Open source software for ARM SoCs

Follow Linaro: <> Facebook |
<!/linaroorg> Twitter |
<> Blog