Re: [PATCH] dma-mapping: Name SG DMA flag helpers consistently

From: Logan Gunthorpe
Date: Tue May 30 2023 - 14:03:18 EST




On 2023-05-25 11:46, Robin Murphy wrote:
> sg_is_dma_bus_address() is inconsistent with the naming pattern of its
> corresponding setters and its own kerneldoc, so take the majority vote
> and rename it sg_dma_is_bus_address() (and fix up the missing
> underscores in the kerneldoc too). This gives us a nice clear pattern
> where SG DMA flags are SG_DMA_<NAME>, and the helpers for acting on them
> are sg_dma_<action>_<name>().
>
> Signed-off-by: Robin Murphy <robin.murphy@xxxxxxx>

Looks good to me. Thanks.

Reviewed-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>