Re: [PATCH net] net: ipa: Use the correct value for IPA_STATUS_SIZE

[Bert Karwatzki]

Am Dienstag, dem 30.05.2023 um 07:29 -0500 schrieb Alex Elder:
> On 5/30/23 4:10 AM, Bert Karwatzki wrote:
> > Am Dienstag, dem 30.05.2023 um 09:09 +0200 schrieb Simon Horman:
> > > On Sat, May 27, 2023 at 10:46:25PM +0200, Bert Karwatzki wrote:
> > > > commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c introduced
> > > > IPA_STATUS_SIZE as a replacement for the size of the removed struct
> > > > ipa_status. sizeof(struct ipa_status) was sizeof(__le32[8]), use this
> > > > as IPA_STATUS_SIZE.
> 
> This is better, however it really isn't done in a way that's
> appropriate for a Linux kernel patch.  I will gladly help you
> get it right if you have the patience for that.  But I'm not
> going to say anything yet--until you say you want me to help
> you do this.  If you prefer, I can submit the patch for you.
> 
> The reason this is important is your commit is permanent, and
> just like code, commit messages are best if kept consistent
> and readable.  I also am offering to help you understand so
> you avoid any trouble next time you want to send a kernel patch.
> 
> Let me know what you prefer.
> 
>                                         -Alex
> 
> > > 

So here's v3 of the patch, done (I hope) in a way that is more standard
conforming.