Re: [PATCH] scsi: lpfc: Replace all non-returning strlcpy with strscpy

[Justin Tee]

Hi Azeem,

Looks good.

Reviewed-by: Justin Tee <justin.tee@xxxxxxxxxxxx>

Thanks,
Justin

On Tue, May 30, 2023 at 8:59 AM Azeem Shaikh <azeemshaikh38@xxxxxxxxx> wrote:
>
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@xxxxxxxxx>
> ---
>  drivers/scsi/lpfc/lpfc_hbadisc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
> index 5ba3a9ad9501..239a6537b987 100644
> --- a/drivers/scsi/lpfc/lpfc_hbadisc.c
> +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c
> @@ -4835,7 +4835,7 @@ lpfc_nlp_state_name(char *buffer, size_t size, int state)
>         };
>
>         if (state < NLP_STE_MAX_STATE && states[state])
> -               strlcpy(buffer, states[state], size);
> +               strscpy(buffer, states[state], size);
>         else
>                 snprintf(buffer, size, "unknown (%d)", state);
>         return buffer;
>