Re: [PATCH v8 2/3] net: dsa: mv88e6xxx: add support for MV88E6020 switch

[Florian Fainelli]

On 5/30/23 01:39, Lukasz Majewski wrote:
> From: Matthias Schiffer <matthias.schiffer@xxxxxxxxxxxxxxx>
>
> A mv88e6250 family switch with 2 PHY and RMII ports and
> no PTP support.
>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@xxxxxxxxxxxxxxx>
> Signed-off-by: Lukasz Majewski <lukma@xxxxxxx>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

> ---
[snip]

>   /* List of supported models */
>   enum mv88e6xxx_model {
> +	MV88E6020,
>   	MV88E6085,
>   	MV88E6095,
>   	MV88E6097,
> @@ -94,7 +95,7 @@ enum mv88e6xxx_family {
>   	MV88E6XXX_FAMILY_6097,	/* 6046 6085 6096 6097 */
>   	MV88E6XXX_FAMILY_6165,	/* 6123 6161 6165 */
>   	MV88E6XXX_FAMILY_6185,	/* 6108 6121 6122 6131 6152 6155 6182 6185 */
> -	MV88E6XXX_FAMILY_6250,	/* 6220 6250 */
> +	MV88E6XXX_FAMILY_6250,	/* 6220 6250 6020 */

über nit: only if you have to resubmit, numbers in ascending order.

Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
--
Florian