Re: Revert "module: error out early on concurrent load of the same module file"'

From: Dan Williams
Date: Tue May 30 2023 - 18:21:40 EST


Luis Chamberlain wrote:
> On Tue, May 30, 2023 at 02:43:12PM -0700, Dan Williams wrote:
> > [ add linux-cxl ]
> >
> > Sedat Dilek wrote:
> > > Hi,
> > >
> > > after building Linux v6.4-rc4 I can NOT boot into my Debian GNU/Linux
> > > AMD64 system with root-ext4 (/dev/sdc2 - of course using UUID in
> > > /etc/fstab).
> >
> > I did not find a mailing-list thread for "9828ed3f695a module: error out early
> > on concurrent load of the same module file", so replying here. This
> > commit breaks the basic CXL smoke test of loading the combination of
> > cxl_acpi, cxl_pci, and cxl_mem modules.
> >
> > Just wanted to highlight this a test case for the next attempt at this
> > fix.
>
> The revert has already been done:

Yup, found that shortly after.

>
> commit ac2263b588dffd3a1efd7ed0b156ea6c5aea200d
> Author: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Date: Mon May 29 06:40:33 2023 -0400
>
> Revert "module: error out early on concurrent load of the same
> module file"
>
> The smoke test, is this the ndctl cxl tests with the mock driver? If so
> then I could use it to test future efforts for alternatives for this
> work before any new changes get merged.

In this case this was even before running those. I typically just run
"cxl list" on my base QEMU config, and if it comes up empty then
something regressed.