Re: [PATCH] gpiolib: Fix GPIO chip IRQ initialization restriction

[Andy Shevchenko]

On Mon, May 29, 2023 at 10:44 AM Jiawen Wu <jiawenwu@xxxxxxxxxxxxxx> wrote:
>
> In case of gpio-regmap, IRQ chip is added by regmap-irq and associated with
> GPIO chip by gpiochip_irqchip_add_domain(). The initialization flag was not
> added in gpiochip_irqchip_add_domain(), causing gpiochip_to_irq() to return
> -EPROBE_DEFER.

Makes sense to me.

> Fixes: 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members before initialization")
> Signed-off-by: Jiawen Wu <jiawenwu@xxxxxxxxxxxxxx>

> Cc: shreeya.patel@xxxxxxxxxxxxx

This can be replaced with the --cc option.

...

>         gc->to_irq = gpiochip_to_irq;
>         gc->irq.domain = domain;

I'm wondering if you need the same (compiler) barrier here as in the
other place.

> +       gc->irq.initialized = true;

--
With Best Regards,
Andy Shevchenko