Re: [PATCH] riscv: mm: Pre-allocate PGD entries vmalloc/modules area
From: kernel test robot
Date: Tue May 30 2023 - 23:40:52 EST
Hi Björn,
kernel test robot noticed the following build errors:
[auto build test ERROR on ac9a78681b921877518763ba0e89202254349d1b]
url: https://github.com/intel-lab-lkp/linux/commits/Bj-rn-T-pel/riscv-mm-Pre-allocate-PGD-entries-vmalloc-modules-area/20230530-020212
base: ac9a78681b921877518763ba0e89202254349d1b
patch link: https://lore.kernel.org/r/20230529180023.289904-1-bjorn%40kernel.org
patch subject: [PATCH] riscv: mm: Pre-allocate PGD entries vmalloc/modules area
config: riscv-randconfig-r042-20230530 (https://download.01.org/0day-ci/archive/20230531/202305311117.huD9v4Y8-lkp@xxxxxxxxx/config)
compiler: riscv64-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/9383adbcdfb7f850149742579615e8c174328a78
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Bj-rn-T-pel/riscv-mm-Pre-allocate-PGD-entries-vmalloc-modules-area/20230530-020212
git checkout 9383adbcdfb7f850149742579615e8c174328a78
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=riscv olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305311117.huD9v4Y8-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
arch/riscv/mm/init.c: In function 'preallocate_pgd_pages_range':
>> arch/riscv/mm/init.c:1381:30: error: implicit declaration of function 'pgd_offset_k'; did you mean 'p4d_offset'? [-Werror=implicit-function-declaration]
1381 | pgd_t *pgd = pgd_offset_k(addr);
| ^~~~~~~~~~~~
| p4d_offset
arch/riscv/mm/init.c:1381:30: warning: initialization of 'pgd_t *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
>> arch/riscv/mm/init.c:1387:23: error: implicit declaration of function 'p4d_alloc'; did you mean 'd_alloc'? [-Werror=implicit-function-declaration]
1387 | p4d = p4d_alloc(&init_mm, pgd, addr);
| ^~~~~~~~~
| d_alloc
arch/riscv/mm/init.c:1387:21: warning: assignment to 'p4d_t *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1387 | p4d = p4d_alloc(&init_mm, pgd, addr);
| ^
>> arch/riscv/mm/init.c:1395:23: error: implicit declaration of function 'pud_alloc'; did you mean 'd_alloc'? [-Werror=implicit-function-declaration]
1395 | pud = pud_alloc(&init_mm, p4d, addr);
| ^~~~~~~~~
| d_alloc
arch/riscv/mm/init.c:1395:21: warning: assignment to 'pud_t *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1395 | pud = pud_alloc(&init_mm, p4d, addr);
| ^
>> arch/riscv/mm/init.c:1403:23: error: implicit declaration of function 'pmd_alloc'; did you mean 'mm_alloc'? [-Werror=implicit-function-declaration]
1403 | pmd = pmd_alloc(&init_mm, pud, addr);
| ^~~~~~~~~
| mm_alloc
arch/riscv/mm/init.c:1403:21: warning: assignment to 'pmd_t *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1403 | pmd = pmd_alloc(&init_mm, pud, addr);
| ^
arch/riscv/mm/init.c: In function 'pgtable_cache_init':
>> arch/riscv/mm/init.c:1421:45: error: 'MODULES_VADDR' undeclared (first use in this function)
1421 | preallocate_pgd_pages_range(MODULES_VADDR, MODULES_END, "bpf/modules");
| ^~~~~~~~~~~~~
arch/riscv/mm/init.c:1421:45: note: each undeclared identifier is reported only once for each function it appears in
>> arch/riscv/mm/init.c:1421:60: error: 'MODULES_END' undeclared (first use in this function)
1421 | preallocate_pgd_pages_range(MODULES_VADDR, MODULES_END, "bpf/modules");
| ^~~~~~~~~~~
cc1: some warnings being treated as errors
vim +1381 arch/riscv/mm/init.c
1366
1367 #ifdef CONFIG_64BIT
1368 /*
1369 * Pre-allocates page-table pages for a specific area in the kernel
1370 * page-table. Only the level which needs to be synchronized between
1371 * all page-tables is allocated because the synchronization can be
1372 * expensive.
1373 */
1374 static void __init preallocate_pgd_pages_range(unsigned long start, unsigned long end,
1375 const char *area)
1376 {
1377 unsigned long addr;
1378 const char *lvl;
1379
1380 for (addr = start; addr < end && addr >= start; addr = ALIGN(addr + 1, PGDIR_SIZE)) {
> 1381 pgd_t *pgd = pgd_offset_k(addr);
1382 p4d_t *p4d;
1383 pud_t *pud;
1384 pmd_t *pmd;
1385
1386 lvl = "p4d";
> 1387 p4d = p4d_alloc(&init_mm, pgd, addr);
1388 if (!p4d)
1389 goto failed;
1390
1391 if (pgtable_l5_enabled)
1392 continue;
1393
1394 lvl = "pud";
> 1395 pud = pud_alloc(&init_mm, p4d, addr);
1396 if (!pud)
1397 goto failed;
1398
1399 if (pgtable_l4_enabled)
1400 continue;
1401
1402 lvl = "pmd";
> 1403 pmd = pmd_alloc(&init_mm, pud, addr);
1404 if (!pmd)
1405 goto failed;
1406 }
1407 return;
1408
1409 failed:
1410 /*
1411 * The pages have to be there now or they will be missing in
1412 * process page-tables later.
1413 */
1414 panic("Failed to pre-allocate %s pages for %s area\n", lvl, area);
1415 }
1416
1417 void __init pgtable_cache_init(void)
1418 {
1419 preallocate_pgd_pages_range(VMALLOC_START, VMALLOC_END, "vmalloc");
1420 if (IS_ENABLED(CONFIG_MODULES))
> 1421 preallocate_pgd_pages_range(MODULES_VADDR, MODULES_END, "bpf/modules");
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki