RE: [PATCH] scsi: ufs: core: Do not open code SZ_x

[Avri Altman]

> >int ufshcd_memory_alloc(struct ufs_hba *hba)
> >
> >       /*
> >        * Allocate memory for UTP Transfer descriptors
> >-       * UFSHCI requires 1024 byte alignment of UTRD
> >+       * UFSHCI requires 1KB alignment of UTRD
> >        */
> >       utrdl_size = (sizeof(struct utp_transfer_req_desc) * hba->nutrs);
> >       hba->utrdl_base_addr = dmam_alloc_coherent(hba->dev, @@ -3773,7
> >+3773,7 @@ static int ufshcd_memory_alloc(struct ufs_hba *hba)
> >                                                  &hba->utrdl_dma_addr,
> >                                                  GFP_KERNEL);
> >       if (!hba->utrdl_base_addr ||
> >-          WARN_ON(hba->utrdl_dma_addr & (1024 - 1))) {
> >+          WARN_ON(hba->utrdl_dma_addr & (SZ_1K - 1))) {
> 
> How about changing the UTMRD part inside ufshcd_memory_alloc() as well?
Oops - missed that.
Thanks,
Avri

> 
> Best Regards,
> Keoseong