Re: [PATCH v3 3/4] md/raid10: fix incorrect done of recovery

From: Li Nan
Date: Wed May 31 2023 - 05:32:39 EST




在 2023/5/31 5:55, Song Liu 写道:
On Sat, May 27, 2023 at 12:24 AM <linan666@xxxxxxxxxxxxxxx> wrote:

From: Li Nan <linan122@xxxxxxxxxx>

Recovery will go to giveup and let chunks_skipped++ in
raid10_sync_request() if there are some bad_blocks, and it will return
max_sector when chunks_skipped >= geo.raid_disks. Now, recovery fail and
data is inconsistent but user think recovery is done, it is wrong.

Fix it by set mirror's recovery_disabled, spare device will not be added
to here. The same issue alos exists on resync, it will be fixd in future.

Signed-off-by: Li Nan <linan122@xxxxxxxxxx>

I applied 1/4 and 2/4 of the set to md-next.

For 3/4 and 4/4, please improve the commit log (rephrase confusing statements,
fix typo's, etc.). Please also add a mdadm test for 3/4.

Thanks,
Song


I will add a test later. Thanks for review.

--
Thanks,
Nan