Re: [PATCH v6 0/7] Add JH7110 USB and USB PHY driver support

[Minda Chen]

On 2023/5/26 17:03, Roger Quadros wrote:
> 
> 
> On 18/05/2023 14:27, Minda Chen wrote:
>> This patchset adds USB driver and USB PHY for the StarFive JH7110 SoC.
>> USB work mode is peripheral and using USB 2.0 PHY in VisionFive 2 board.
>> The patch has been tested on the VisionFive 2 board.
>> 
>> This patchset should be applied after the patchset [1], [2] and [3]:
>> [1] https://patchwork.kernel.org/project/linux-riscv/cover/20230518101234.143748-1-xingyu.wu@xxxxxxxxxxxxxxxx/
>> [2] https://patchwork.kernel.org/project/linux-clk/cover/20230512022036.97987-1-xingyu.wu@xxxxxxxxxxxxxxxx
>> [3] https://patchwork.kernel.org/project/linux-phy/cover/20230412084540.295411-1-changhuang.liang@xxxxxxxxxxxxxxxx/
>> 
>> This patchset is base on v6.4-rc1
>> 
>> patch 1 is usb phy dt-binding document.
>> patch 2 is Pcie PHY dt-binding document.
>> patch 3 is USB 2.0 PHY driver.
>> patch 4 is PCIe PHY driver.
>> patch 5 is usb dt-binding document.
>> patch 6 is the wrapper module driver of Cadence USB3. USB controller IP is Cadence USB3.
>> patch 7 is USB device tree configuration.
>> 
>> previous version
>> ---
>> version 1 patchset are split to different kernel organization. It is
>> incorrect. But they were sent, and Emil sent comments. I think I should 
>> reserve them in cover-letter. To read the change records and previous version, 
>> please start with version 2. 
>> 
>> v1: https://patchwork.kernel.org/project/linux-usb/cover/20230306095212.25840-1-minda.chen@xxxxxxxxxxxxxxxx/
>> v2: https://patchwork.kernel.org/project/linux-usb/cover/20230308082800.3008-1-minda.chen@xxxxxxxxxxxxxxxx/
>> v3: https://patchwork.kernel.org/project/linux-usb/cover/20230315104411.73614-1-minda.chen@xxxxxxxxxxxxxxxx/
>> v4: https://patchwork.kernel.org/project/linux-usb/cover/20230406015216.27034-1-minda.chen@xxxxxxxxxxxxxxxx/
>> v5: https://patchwork.kernel.org/project/linux-usb/cover/20230420110052.3182-1-minda.chen@xxxxxxxxxxxxxxxx/
>> 
>> changes
>> v6:
>>   1. (patch 3) remove the platform remove function.
>>   2. (patch 4)
>>      - add switch to pcie mode function.
>>      - remove the redundant init/exit function.
>>   3. (patch 5)
>>      - dts split to wrapper layer and cdns node. The codes are
>>        like v3.
>>      - add cdns3 sub node dts-binding references.
>>   4. (patch 6)
>>      For stg-syscon iomem 0x10240000 - 0x10240010 actually is belonged
>>      to usb, so USB contain its own registers. So do not merge the dts node.
>>      The codes are like v3.
>>      - remove the cdns3_platform_add function.
>>      - remove phy ops because cdns3 contain all the phy ops.
>>      - runtime suspend function just shutdown the clocks.
>>   5. (patch 7)
>>      - add cdns3 subnode again.
>> 
>> v5:
>>   1. (patch 1) set correct model name and commit title.
>>   2. (patch 2) change to '-item' in syscon property. change commit title.
>>   3. (patch 5)
>>      - change to '-item' in syscon configure.
>>      - change commit title and doc title.
>>   4. (patch 6)
>>      - add clk and phy deinit function
>>      - add clk deinit function if phy init failed.
>>      - coding style changes and other format changes. 
>> 
>> v4:
>>   1. (patch 1) split PCIe PHY dt-binding doc to patch 2.
>>   2. (patch 2) PCIe PHY add stg and sys con configuration to dt-binding doc.
>>   3. (patch 3)
>>      - split PCIe PHY driver to patch 4.
>>      - replace dr_mode to phy mode in jh7110_usb2_phy.
>>   4. (patch 4) 
>>      - Makefile and Kconfig sorted by alphabet sequence.
>>      - Add PCIe PHY stg and syscon PHY connection configuration
>>        for USB 3.0.
>>   5. (patch 5)
>>      - commit message changed.
>>      - merge wrapper dts node and cdns3 node in example.
>>      - Add interrupts, reg, phy and dr_mode in property.
>>      - Add reset-name in property example.
>>   6. (patch 6)
>>      - For dts node is merged, Using platform_device_alloc and
>>        platform_device_add to generate cadence sub device.
>>      - IOMEM and IRQ resource are passed to Cadence sub device.
>>      - Add PHY ops process for PHY dts setting can not be passed to
>>        Cadence USB driver.
>>      - remove the stg and sys USB 3.0 PHY configuration.
>>      - Change the suspend clock reset and clock enable sequence.
>>      - Get all reset and clock resources before enable them in 
>>        cdns_clk_rst_init.
>>      - commit message changed.
>>   7. (patch 7)
>>      - merge wrapper dts node and cdns3 node in usb dts.
>>      - move the stg and sys USB 3.0 PHY confiuration to
>>        PCIe PHY dts node.
>>      - commit message changed.
>>      - Add reset-names dts.
>> 
>> v3:
>>   1. Add patch 1 - 4. Add USB PHY driver and dt-binding doc. 
>>      USB PHY codes are moved to patch 3 and patch 4.
>>   2. (patch 5)
>>      - USB wrapper module dts document is moved to usb directory.
>>      - Remove the 'dr_mode' and 'starfive,usb2-only' setting.
>>      - Some dts format changes. dts binding check pass.
>>   3. (patch 6)
>>      - Remove the PHY codes. 
>>      - Search 'dr_mode' and phy setting from Cadence subnode.
>>   4. (patch 7)
>>      - Add USB PHY dts configurion. 
>>      - 'dr_mode' is moved to Cadence controller submode.
>> 
>> v2:
>>   1. (patch 5) dt-binding changes. The document example is the same as dts config.
>>   2. (patch 6) using dev_err_probe and syscon_regmap_lookup_by_phandle_args function. Some formats changes
>>   3. (patch 7) dts nodes sorted by the address after @
>> 
>> Minda Chen (7):
>>   dt-bindings: phy: Add StarFive JH7110 USB PHY
>>   dt-bindings: phy: Add StarFive JH7110 PCIe PHY
>>   phy: starfive: Add JH7110 USB 2.0 PHY driver
>>   phy: starfive: Add JH7110 PCIE 2.0 PHY driver
>>   dt-bindings: usb: Add StarFive JH7110 USB controller
>>   usb: cdns3: Add StarFive JH7110 USB driver
>>   riscv: dts: starfive: Add USB dts configuration for JH7110
>> 
>>  .../phy/starfive,jh7110-pcie-phy.yaml         |  58 +++++
>>  .../bindings/phy/starfive,jh7110-usb-phy.yaml |  50 ++++
>>  .../bindings/usb/starfive,jh7110-usb.yaml     | 115 ++++++++
>>  MAINTAINERS                                   |  14 +
>>  .../jh7110-starfive-visionfive-2.dtsi         |   5 +
>>  arch/riscv/boot/dts/starfive/jh7110.dtsi      |  53 ++++
>>  drivers/phy/starfive/Kconfig                  |  21 ++
>>  drivers/phy/starfive/Makefile                 |   2 +
>>  drivers/phy/starfive/phy-jh7110-pcie.c        | 204 +++++++++++++++
>>  drivers/phy/starfive/phy-jh7110-usb.c         | 150 +++++++++++
>>  drivers/usb/cdns3/Kconfig                     |  11 +
>>  drivers/usb/cdns3/Makefile                    |   1 +
>>  drivers/usb/cdns3/cdns3-starfive.c            | 246 ++++++++++++++++++
>>  13 files changed, 930 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-pcie-phy.yaml
>>  create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-usb-phy.yaml
>>  create mode 100644 Documentation/devicetree/bindings/usb/starfive,jh7110-usb.yaml
>>  create mode 100644 drivers/phy/starfive/phy-jh7110-pcie.c
>>  create mode 100644 drivers/phy/starfive/phy-jh7110-usb.c
>>  create mode 100644 drivers/usb/cdns3/cdns3-starfive.c
>> 
> 
> For this series:
> Reviewed-by: Roger Quadros <rogerq@xxxxxxxxxx>

Thanks Roger， Coner and Greg.
Patch 6 (USB controller codes) are accepted. 

Thanks Rob and Krzysztof.
  Dts-binding doc are reviewed.

Hi Vinod , Kishon and Linux-PHY maintainer
  Could you take time to review USB PHY codes (patch 3 and patch4) ? Thanks