Re: [PATCH v2 04/12] dmaengine: fsl-edma: remove v3 from enum edma_version

From: Frank Li
Date: Wed May 31 2023 - 08:53:19 EST


On Wed, May 31, 2023 at 02:50:57PM +0800, Peng Fan wrote:
>
>
> On 5/30/2023 4:04 AM, Frank Li wrote:
> > static struct fsl_edma_drvdata imx7ulp_data = {
> > - .version = v3,
> > + .version = v1,
>
> This may confuse people.How about for hardware
> version >= v3, use new flag as yours?

I can use drvflags to distinguish. I checked spec, 7ULP called eDMA2.
Okay, let me change to check drvflags.

Anyways, we should align version with hardware IP version, or not
use it at all.

Frank

>
> Regards,
> Peng.