Re: [PATCH] ARM: Replace all non-returning strlcpy with strscpy

From: Linus Walleij
Date: Wed May 31 2023 - 09:32:09 EST

On Tue, May 30, 2023 at 5:55 PM Azeem Shaikh <azeemshaikh38@xxxxxxxxx> wrote:

> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
> [1]
> [2]
> Signed-off-by: Azeem Shaikh <azeemshaikh38@xxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Please put this into Russell's patch tracker:

Linus Walleij