Re: [PATCH v2 2/6] dt-bindings: sound: cirrus,cs42l43: Add initial DT binding
From: Charles Keepax
Date: Wed May 31 2023 - 10:16:07 EST
On Wed, May 31, 2023 at 11:02:24AM +0200, Krzysztof Kozlowski wrote:
> On 30/05/2023 14:21, Charles Keepax wrote:
> > + cirrus,bias-sense-ua:
>
> "ua" looks like microamp. If so, microamp instead:
> https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml
>
> > + pinctrl:
> > + type: object
> > +
> > + allOf:
>
> Drop allOf, just "$ref: ......"
>
> > + - $ref: /schemas/pinctrl/pinctrl.yaml#
> > +
> > + additionalProperties: false
>
> Also drop blank lines between these three above.
>
> > + patternProperties:
> > + "-state$":
>
> Use consistent quotes, either " or ' everywhere
>
Thanks, will fix those all up for v3.
Thanks,
Charles