Re: [PATCH v6 0/7] refactor file signing program
From: Greg KH
Date: Wed May 31 2023 - 12:50:28 EST
On Wed, May 31, 2023 at 09:01:24PM +0530, Shreenidhi Shedi wrote:
> On Wed, 31-May-2023 20:08, Greg KH wrote:
> > On Tue, Apr 25, 2023 at 04:14:49PM +0530, Shreenidhi Shedi wrote:
> > > On Wed, 22-Mar-2023 01:03, Shreenidhi Shedi wrote:
> > > Can you please review the latest patch series? I think I have addressed your
> > > concerns. Thanks.
> >
> > The big question is, "who is going to use these new features"? This
> > tool is only used by the in-kernel build scripts, and if they do not
> > take advantage of these new options you have added, why are they needed?
> >
> > thanks,
> >
> > greg k-h
>
> Hi Greg,
>
> Thanks for the response.
>
> We use it in VMware Photon OS. Following is the link for the same.
> https://github.com/vmware/photon/blob/master/SPECS/linux/spec_install_post.inc#L4
>
> If this change goes in, it will give a slight push to our build performance.
What exactly do you mean by "slight push"?
> Can you please take these changes?
Why would we take changes for something that will not benifit us at all?
You are asking us to maintain code that only benifits your out-of-tree
usecase, which is not how kernel development works (and you don't want
it to work that way...)
thanks,
greg k-h