Re: [PATCH v2] PCI: Add dummy implement for pci_clear_master() function

[Sui Jingfeng]

Hi,


Thanks a lot.

Can you receive my email?

I reply several email to you, but Thunderbird told me that may mail is 
returned.

Maybe you could read the content at lore.

```

The recipient's server is busy or down now.
SMTP error, OPEN: Host kernel.org(35.85.114.177) OPEN said 521 5.7.1 Service unavailable; client [114.242.206.163] blocked using zen.spamhaus.org

```


On 2023/6/1 01:28, Bjorn Helgaas wrote:
> On Wed, May 31, 2023 at 06:27:44PM +0800, Sui Jingfeng wrote:
> > As some arch(m68k for example) doesn't have config_pci enabled, drivers[1]
> > call pci_clear_master() without config_pci guard can not pass compile test.
> >
> >     drivers/gpu/drm/etnaviv/etnaviv_pci_drv.c:
> >     In function 'etnaviv_gpu_pci_fini':
> > > > drivers/gpu/drm/etnaviv/etnaviv_pci_drv.c:32:9:
> >     error: implicit declaration of function 'pci_clear_master';
> >     did you mean 'pci_set_master'? [-Werror=implicit-function-declaration]
> >        32 |         pci_clear_master(pdev);
> >           |         ^~~~~~~~~~~~~~~~
> >           |         pci_set_master
> >     cc1: some warnings being treated as errors
> >
> > [1] https://patchwork.freedesktop.org/patch/539977/?series=118522&rev=1
> >
> > V2:
> > 	* Adjust commit log style to meet the convention and add Fixes tag
> >
> > Fixes: 6a479079c072 ("PCI: Add pci_clear_master() as opposite of pci_set_master()")
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202305301659.4guSLavL-lkp@xxxxxxxxx/
> > Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > Signed-off-by: Sui Jingfeng <suijingfeng@xxxxxxxxxxx>
> Applied to pci/misc for v6.5 as follows:
>
>    Author: Sui Jingfeng <suijingfeng@xxxxxxxxxxx>
>    Date:   Wed May 31 18:27:44 2023 +0800
>
>      PCI: Add pci_clear_master() stub for non-CONFIG_PCI
>      
>      Add a pci_clear_master() stub when CONFIG_PCI is not set so drivers that
>      support both PCI and platform devices don't need #ifdefs or extra Kconfig
>      symbols for the PCI parts.
>      
>      [bhelgaas: commit log]
>      Fixes: 6a479079c072 ("PCI: Add pci_clear_master() as opposite of pci_set_master()")
>      Link: https://lore.kernel.org/r/20230531102744.2354313-1-suijingfeng@xxxxxxxxxxx
>      Signed-off-by: Sui Jingfeng <suijingfeng@xxxxxxxxxxx>
>      Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>      Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>
> > ---
> >   include/linux/pci.h | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/include/linux/pci.h b/include/linux/pci.h
> > index d0c19ff0c958..71c85380676c 100644
> > --- a/include/linux/pci.h
> > +++ b/include/linux/pci.h
> > @@ -1904,6 +1904,7 @@ static inline int pci_dev_present(const struct pci_device_id *ids)
> >   #define pci_dev_put(dev)	do { } while (0)
> >   
> >   static inline void pci_set_master(struct pci_dev *dev) { }
> > +static inline void pci_clear_master(struct pci_dev *dev) { }
> >   static inline int pci_enable_device(struct pci_dev *dev) { return -EIO; }
> >   static inline void pci_disable_device(struct pci_dev *dev) { }
> >   static inline int pcim_enable_device(struct pci_dev *pdev) { return -EIO; }
> > --
> > 2.25.1