Re: [PATCH net] neighbour: fix unaligned access to pneigh_entry

From: Jakub Kicinski
Date: Wed May 31 2023 - 14:16:17 EST

On Wed, 31 May 2023 18:42:33 +0800 Qingfang DENG wrote:
> u8 key[];
> +#else
> + u8 key[] __aligned(4);
> +#endif

I'd appreciate a second opinion, but to me it's very unlikely we'd save
any memory even with efficient aligned access here. No reasonably key
will fit into 3 bytes, right? So we can as well avoid the ifdef and
make the key[] always aligned. Or preferably, if it doesn't cause
compilation issues, make the type of the key u32?