Re: [PATCH] KVM: VMX: restore vmx_vmexit alignment

[Jon Kohler]

> On May 31, 2023, at 2:20 PM, Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
> 
> On Wed, May 31, 2023, Jon Kohler wrote:
>> Commit 8bd200d23ec4 ("KVM: VMX: Flatten __vmx_vcpu_run()") changed
>> vmx_vmexit from SYM_FUNC_START to SYM_INNER_LABEL, accidentally
>> removing 16 byte alignment as SYM_FUNC_START uses SYM_A_ALIGN and
>> SYM_INNER_LABEL does not. Josh mentioned [1] this was unintentional.
> 
> Anyone know if this is this stable material, or just nice to have?

I’m on the fence, though my vote is nice to have, its been this way for a while, 
nothing actively breaks one way or the other, and I don’t think there is a specific
security concern. It’s trivial enough though so it could easily just go the other way. 

Will defer to Josh/the crowd if I’m missing something though.