Re: [PATCH net v2] net/mlx5: Fix setting of irq->map.index for static IRQ case

[Saeed Mahameed]

On 31 May 11:38, Cédric Le Goater wrote:
> On 5/31/23 10:48, Niklas Schnelle wrote:
> > When dynamic IRQ allocation is not supported all IRQs are allocated up
> > front in mlx5_irq_table_create() instead of dynamically as part of
> > mlx5_irq_alloc(). In the latter dynamic case irq->map.index is set
> > via the mapping returned by pci_msix_alloc_irq_at(). In the static case
> > and prior to commit 1da438c0ae02 ("net/mlx5: Fix indexing of mlx5_irq")
> > irq->map.index was set in mlx5_irq_alloc() twice once initially to 0 and
> > then to the requested index before storing in the xarray. After this
> > commit it is only set to 0 which breaks all other IRQ mappings.
> >
> > Fix this by setting irq->map.index to the requested index together with
> > irq->map.virq and improve the related comment to make it clearer which
> > cases it deals with.
> >
> > Tested-by: Mark Brown <broonie@xxxxxxxxxx>
> > Reviewed-by: Mark Brown <broonie@xxxxxxxxxx>
> > Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>
> > Reviewed-by: Eli Cohen <elic@xxxxxxxxxx>
> > Fixes: 1da438c0ae02 ("net/mlx5: Fix indexing of mlx5_irq")
> > Signed-off-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx>

Applied to net-mlx5. 

Thanks.