Re: [PATCH v7 4/4] dt-bindings: mtd: marvell-nand: Remove deprecated compatibles

From: Chris Packham
Date: Wed May 31 2023 - 18:36:37 EST



On 31/05/23 19:33, Miquel Raynal wrote:
> Hi Chris,
>
> chris.packham@xxxxxxxxxxxxxxxxxxx wrote on Wed, 31 May 2023 11:54:56
> +1200:
>
>> Remove compatible values that were marked as deprecated in the old text
>> binding.
>>
>> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
>> ---
>> .../devicetree/bindings/mtd/marvell,nand-controller.yaml | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml
>> index 7cd4a2e99343..80ce854291cb 100644
>> --- a/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml
>> +++ b/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml
>> @@ -18,9 +18,6 @@ properties:
>> - enum:
>> - marvell,armada370-nand-controller
>> - marvell,pxa3xx-nand-controller
>> - - marvell,armada-8k-nand
>> - - marvell,armada370-nand
>> - - marvell,pxa3xx-nand
> Not sure what you're doing here?
That's me being in an awkward timezone and guessing (badly). I think
I've got the deprecated compatibles sorted now so I'll drop this from v8.
> I would actually expect these three
> lines to have something along:
>
> deprecated: true
>
> and this should be part of the conversion to yaml. Or perhaps I am
> missing something?
>
> The rest of the series looks good to me.
>
>>
>> reg:
>> maxItems: 1
>
> Thanks,
> Miquèl