Re: [PATCH] scsi: libfcoe: Replace all non-returning strlcpy with strscpy

From: Azeem Shaikh
Date: Wed May 31 2023 - 18:40:43 EST


On Wed, May 31, 2023 at 6:03 PM Martin K. Petersen
<martin.petersen@xxxxxxxxxx> wrote:
>
>
> Azeem,
>
> > strlcpy() reads the entire source buffer first. This read may exceed
> > the destination size limit. This is both inefficient and can lead to
> > linear read overflows if a source string is not NUL-terminated [1]. In
> > an effort to remove strlcpy() completely [2], replace strlcpy() here
> > with strscpy(). No return values were used, so direct replacement is
> > safe.
>
> Applied to 6.5/scsi-staging!

Thanks Martin!

>
> PS. It would help if you could submit changes like these as a series in
> the future so I don't have to track each patch individually.
>

Sure, I can do that.