Re: [PATCH v2 4/6] dt-bindings: sram: qcom,ocmem: Add msm8226 support

From: Krzysztof Kozlowski
Date: Thu Jun 01 2023 - 03:10:08 EST


On 23/05/2023 22:55, Luca Weiss wrote:
> Add the compatible for the OCMEM found on msm8226 which compared to
> msm8974 only has a core clock and no iface clock.
>
> Signed-off-by: Luca Weiss <luca@xxxxxxxxx>
> ---
> .../devicetree/bindings/sram/qcom,ocmem.yaml | 20 +++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml b/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml
> index 4bbf6db0b6bd..02e4da9649fd 100644
> --- a/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml
> +++ b/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml
> @@ -15,7 +15,9 @@ description: |
>
> properties:
> compatible:
> - const: qcom,msm8974-ocmem
> + enum:
> + - qcom,msm8226-ocmem # v1.1.0
> + - qcom,msm8974-ocmem # v1.4.0
>
> reg:
> items:
> @@ -28,11 +30,13 @@ properties:
> - const: mem
>
> clocks:
> + minItems: 1
> items:
> - description: Core clock
> - description: Interface clock
>
> clock-names:
> + minItems: 1
> items:
> - const: core
> - const: iface
> @@ -58,6 +62,20 @@ required:
>
> additionalProperties: false
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,msm8974-ocmem
> + then:
> + properties:
> + clocks:
> + minItems: 2
> + clock-names:
> + minItems: 2

else:
maxItems: 1?

Best regards,
Krzysztof