Re: [PATCH v1 40/43] ARM: ep93xx: soc: drop defines

From: kernel test robot
Date: Thu Jun 01 2023 - 10:20:50 EST

Hi Nikita,

kernel test robot noticed the following build warnings:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on linusw-pinctrl/devel linusw-pinctrl/for-next linus/master v6.4-rc4]
[cannot apply to soc/for-next robh/for-next next-20230601]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Nikita-Shubin/dt-bindings-soc-Add-Cirrus-EP93xx/20230601-143415
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
patch link: https://lore.kernel.org/r/20230601054549.10843-22-nikita.shubin%40maquefel.me
patch subject: [PATCH v1 40/43] ARM: ep93xx: soc: drop defines
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20230601/202306011611.BkjkqkuR-lkp@xxxxxxxxx/config)
compiler: alpha-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/372fa9eb75b475c6b8f26079e8716c95622ae9b7
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Nikita-Shubin/dt-bindings-soc-Add-Cirrus-EP93xx/20230601-143415
git checkout 372fa9eb75b475c6b8f26079e8716c95622ae9b7
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=alpha olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash drivers/input/keyboard/ sound/soc/cirrus/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306011611.BkjkqkuR-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

In file included from drivers/input/keyboard/ep93xx_keypad.c:30:
include/linux/soc/cirrus/ep93xx.h: In function 'ep93xx_devcfg_set_clear':
include/linux/soc/cirrus/ep93xx.h:22:16: error: 'return' with a value, in function returning void [-Werror=return-type]
22 | return 0;
| ^
include/linux/soc/cirrus/ep93xx.h:19:20: note: declared here
19 | static inline void ep93xx_devcfg_set_clear(unsigned int set_bits,
| ^~~~~~~~~~~~~~~~~~~~~~~
include/linux/soc/cirrus/ep93xx.h: At top level:
>> include/linux/soc/cirrus/ep93xx.h:24:6: warning: no previous prototype for 'ep93xx_syscon_swlocked_write' [-Wmissing-prototypes]
24 | void ep93xx_syscon_swlocked_write(unsigned int val, unsigned int reg)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/soc/cirrus/ep93xx.h: In function 'ep93xx_syscon_swlocked_write':
include/linux/soc/cirrus/ep93xx.h:26:16: error: 'return' with a value, in function returning void [-Werror=return-type]
26 | return 0;
| ^
include/linux/soc/cirrus/ep93xx.h:24:6: note: declared here
24 | void ep93xx_syscon_swlocked_write(unsigned int val, unsigned int reg)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/soc/cirrus/ep93xx.h: At top level:
>> include/linux/soc/cirrus/ep93xx.h:28:6: warning: no previous prototype for 'ep93xx_swlocked_update_bits' [-Wmissing-prototypes]
28 | void ep93xx_swlocked_update_bits(unsigned int reg,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/soc/cirrus/ep93xx.h: In function 'ep93xx_swlocked_update_bits':
include/linux/soc/cirrus/ep93xx.h:31:16: error: 'return' with a value, in function returning void [-Werror=return-type]
31 | return 0;
| ^
include/linux/soc/cirrus/ep93xx.h:28:6: note: declared here
28 | void ep93xx_swlocked_update_bits(unsigned int reg,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/input/keyboard/ep93xx_keypad.c: In function 'ep93xx_keypad_probe':
drivers/input/keyboard/ep93xx_keypad.c:262:9: error: implicit declaration of function 'of_property_read_u32' [-Werror=implicit-function-declaration]
262 | of_property_read_u32(np, "cirrus,debounce-delay-ms", &keypad->debounce);
| ^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
In file included from sound/soc/cirrus/ep93xx-i2s.c:28:
include/linux/soc/cirrus/ep93xx.h: In function 'ep93xx_devcfg_set_clear':
include/linux/soc/cirrus/ep93xx.h:22:16: error: 'return' with a value, in function returning void [-Werror=return-type]
22 | return 0;
| ^
include/linux/soc/cirrus/ep93xx.h:19:20: note: declared here
19 | static inline void ep93xx_devcfg_set_clear(unsigned int set_bits,
| ^~~~~~~~~~~~~~~~~~~~~~~
include/linux/soc/cirrus/ep93xx.h: At top level:
>> include/linux/soc/cirrus/ep93xx.h:24:6: warning: no previous prototype for 'ep93xx_syscon_swlocked_write' [-Wmissing-prototypes]
24 | void ep93xx_syscon_swlocked_write(unsigned int val, unsigned int reg)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/soc/cirrus/ep93xx.h: In function 'ep93xx_syscon_swlocked_write':
include/linux/soc/cirrus/ep93xx.h:26:16: error: 'return' with a value, in function returning void [-Werror=return-type]
26 | return 0;
| ^
include/linux/soc/cirrus/ep93xx.h:24:6: note: declared here
24 | void ep93xx_syscon_swlocked_write(unsigned int val, unsigned int reg)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/soc/cirrus/ep93xx.h: At top level:
>> include/linux/soc/cirrus/ep93xx.h:28:6: warning: no previous prototype for 'ep93xx_swlocked_update_bits' [-Wmissing-prototypes]
28 | void ep93xx_swlocked_update_bits(unsigned int reg,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/soc/cirrus/ep93xx.h: In function 'ep93xx_swlocked_update_bits':
include/linux/soc/cirrus/ep93xx.h:31:16: error: 'return' with a value, in function returning void [-Werror=return-type]
31 | return 0;
| ^
include/linux/soc/cirrus/ep93xx.h:28:6: note: declared here
28 | void ep93xx_swlocked_update_bits(unsigned int reg,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors


vim +/ep93xx_syscon_swlocked_write +24 include/linux/soc/cirrus/ep93xx.h

10
11 #if defined(CONFIG_ARCH_EP93XX)
12 unsigned int ep93xx_chip_revision(void);
13 void ep93xx_devcfg_set_clear(unsigned int set_bits, unsigned int clear_bits);
14 void ep93xx_syscon_swlocked_write(unsigned int val, unsigned int reg);
15 void ep93xx_swlocked_update_bits(unsigned int reg,
16 unsigned int mask, unsigned int val);
17 #else
18 static inline unsigned int ep93xx_chip_revision(void) { return 0; }
19 static inline void ep93xx_devcfg_set_clear(unsigned int set_bits,
20 unsigned int clear_bits)
21 {
> 22 return 0;
23 }
> 24 void ep93xx_syscon_swlocked_write(unsigned int val, unsigned int reg)
25 {
> 26 return 0;
27 }
> 28 void ep93xx_swlocked_update_bits(unsigned int reg,
29 unsigned int mask, unsigned int val)
30 {
31 return 0;
32 }
33 #endif
34

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki