Re: [PATCH 6.1 00/42] 6.1.32-rc1 review

[Guenter Roeck]

On 6/1/23 07:26, Greg Kroah-Hartman wrote:
> On Thu, Jun 01, 2023 at 07:41:08PM +0530, Naresh Kamboju wrote:
> > On Thu, 1 Jun 2023 at 18:57, Greg Kroah-Hartman
> > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > > This is the start of the stable review cycle for the 6.1.32 release.
> > > There are 42 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Sat, 03 Jun 2023 13:19:19 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > >          https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.32-rc1.gz
> > > or in the git tree and branch at:
> > >          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> >
> > Following build errors noticed on 6.1 and 5.15.
> >
> > drivers/dma/at_xdmac.c: In function 'atmel_xdmac_resume':
> > drivers/dma/at_xdmac.c:2049:9: error: implicit declaration of function
> > 'pm_runtime_get_noresume' [-Werror=implicit-function-declaration]
> >   2049 |         pm_runtime_get_noresume(atxdmac->dev);
> >        |         ^~~~~~~~~~~~~~~~~~~~~~~
> > drivers/dma/at_xdmac.c:2049:40: error: 'struct at_xdmac' has no member
> > named 'dev'
> >   2049 |         pm_runtime_get_noresume(atxdmac->dev);
> >        |                                        ^~
> > cc1: some warnings being treated as errors
> >
> > reported link:
> > https://lore.kernel.org/stable/CA+G9fYswtPyrYJbwcGFhc5o7mkRmWZEWCCeSjmR64M+N-odQhQ@xxxxxxxxxxxxxx/
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>
>
> Ah, the .h file was added by 650b0e990cbd ("dmaengine: at_xdmac: add
> runtime pm support"), which isn't needed here.  I'll go add it by hand

Really ? Some of the dma patches seem to fix runtime pm support, and
"dmaengine: at_xdmac: disable/enable clock directly on suspend/resume"
is even tagged with

Fixes: 650b0e990cbd ("dmaengine: at_xdmac: add runtime pm support")

Why do we need to fix code which isn't present in 6.1.y ?

Guenter

> and push out some -rc2 releases for this and 5.15.y, thanks!
>
> greg k-h